fix(wallets): correct disconnect handling for Pera and Defly #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disconnect event listeners for Pera (v1), Pera (v2), and Defly wallets are now properly registered after successful connection. This ensures that deleting a session in the wallet's mobile app triggers the `onDisconnect` method, correctly updating the `WalletProvider` store. - Moved disconnect event listener registration to the `connect` method - Removed premature event listener registration in `initializeClient`
The `onDisconnect` method in `BaseWallet` is now an arrow function to preserve the correct 'this' context when called as an event listener. This fixes an issue where 'this.store' was undefined in `removeWallet` when the disconnect event was triggered. - Changed `onDisconnect` from a regular method to an arrow function - Added debug logging when removing wallet from store
- Add tests for disconnect event listener registration - Implement tests for handling disconnect events - Update mock structures for Pera and Defly wallets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the disconnect event handling for Pera and Defly wallets. It addresses an issue where the wallet state wasn't updating correctly when a session was deleted in the mobile app.
Details
connectmethodThis fix improves wallet connection management reliability, especially when disconnecting from the mobile app. Users will now see the correct wallet state in their applications after external disconnection.
Closes #271