feat(wallets): add WalletConnect v1 session management #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces WalletConnect v1 session management functionality for Pera (v1) and Defly wallets to improve multi-wallet support. - Added `manageWalletConnectSession` method to Pera and Defly wallet classes - Implemented session backup and restore logic in `connect` and `setActive` methods - Updated `StorageAdapter` mock in tests to handle WalletConnect data - Added new test cases for WalletConnect session management
- Move `manageWalletConnectSession` to `BaseWallet` - Update `connect`, `disconnect`, and `setActive` methods - Add delay after disconnect to prevent race condition - Adjust tests to reflect new behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the WalletConnect session management for Defly and Pera wallets, addressing the issues with session persistence and wallet switching described in issue #274. It implements a more robust approach to backing up and restoring WalletConnect sessions, resolving the problems with lost connections and improving overall wallet management reliability.
Details
manageWalletConnectSessionmethod toBaseWalletclass for centralized session managementconnect,disconnect, andsetActivemethods in Defly and Pera (v1) wallet classes to use the new session management approachclient.disconnect()to prevent race conditionsThese changes ensure that WalletConnect sessions are properly maintained when connecting multiple wallets, preventing local storage key collisions and fixing issues caused by lost session data.
Closes #274