feat(*): replace isReconnecting with unified isReady state #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `managerStatus` to track wallet manager initialization state and expose `isReady` getter in React, Vue, and Solid implementations. This allows consumers to know when the wallet manager has completed initialization and is ready for use. - Add `managerStatus` to `State` type and `defaultState` - Add `status` and `isReady` getters to `WalletManager` class - Remove `isReconnecting` from React implementation (see PR #330) - Add `isReady` to all framework implementations - Add tests for `isReady` behavior
Replace `isReconnecting` with `isReady` in React quick start guide to reflect the new unified approach to wallet manager initialization state across all framework implementations. Update example code and description to be more descriptive and user-friendly.
|
Hey @drichar, sorry for completely missing your comment on the other PR! I really appreciate you taking the time to expand on the idea and generalize it across all frameworks. Your approach with isReady makes a lot of sense and keeps things more consistent across the library. Great work, and thanks for building on this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on @stefanofa's excellent contribution in #330 which added
isReconnectingto the React implementation. It expands that concept into a unifiedisReadystate that works consistently across all framework implementations (React, Vue, and Solid).Details
managerStatusto core state managementisReadygetter toWalletManagerclassisReconnectingstateisReadyto all framework implementations