Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Promise's with Observables #631

Closed
nhhockeyplayer opened this issue Nov 13, 2021 · 3 comments
Closed

replace Promise's with Observables #631

nhhockeyplayer opened this issue Nov 13, 2021 · 3 comments
Labels
feature Adds a new Feature or Request typegoose: working as intended Its a typegoose functionality, which is working as intended uses: nestjs & nestjs-typegoose This Issue is using nestjs-typegoose wont fix This will likely never be worked on

Comments

@nhhockeyplayer
Copy link

nhhockeyplayer commented Nov 13, 2021 •
edited
Loading

I was one of the first to spot typegoose early on version 4/5 and released a product fairly rapidly fluid no issues fast and its been bulletproof since.
@nhhockeyplayer nhhockeyplayer added the feature Adds a new Feature or Request label Nov 13, 2021
@hasezoey hasezoey added the info needed Extra information is needed label Nov 13, 2021
@hasezoey
Copy link
Member

I was disheartened to see typegoose copying the typeorm model built on Promises

from what i know, typegoose does not use promises outside of tests

remember, typegoose is a library built on-top of mongoose, and from what i can tell, all typegoose functions are sync

@hasezoey
Copy link
Member

and let me know if he COULD have done it with Observables?

please let know what can be done

sorry, but i dont have experience in nestjs or observables

@hasezoey hasezoey added typegoose: working as intended Its a typegoose functionality, which is working as intended uses: nestjs & nestjs-typegoose This Issue is using nestjs-typegoose wont fix This will likely never be worked on and removed info needed Extra information is needed labels Nov 13, 2021
@hasezoey
Copy link
Member

i will close this, because it is not related to typegoose itself

@nhhockeyplayer nhhockeyplayer mentioned this issue Nov 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Adds a new Feature or Request typegoose: working as intended Its a typegoose functionality, which is working as intended uses: nestjs & nestjs-typegoose This Issue is using nestjs-typegoose wont fix This will likely never be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhhockeyplayer @hasezoey