Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tslint-react rule: jsx-alignment #515

Closed
JoshuaKGoldberg opened this issue May 9, 2020 · 2 comments
Closed

Missing tslint-react rule: jsx-alignment #515

JoshuaKGoldberg opened this issue May 9, 2020 · 2 comments
Labels
area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! status: blocked We can't make progress on this issue until something else is resolved...

Comments

@JoshuaKGoldberg
Copy link
Member

Missing Converter

  • tslint-to-eslint-config version: 1.0.0-beta

  • typescript-eslint version: 2.31.0

TSLint Rule Name

jsx-alignment

Package Source

tslint-react: https://github.com/palantir/tslint-react (see #rules)

Equivalents for tslint-react rules generally live in eslint-plugin-react. If an ESLint rule equivalent doesn't yet exist, this tslint-to-eslint-config issue can be closed until that equivalent is created.

@JoshuaKGoldberg JoshuaKGoldberg added area: missing converter A rule converter should exist but doesn't yet. status: accepting prs Please, send in a PR to resolve this! ✨ labels May 9, 2020
@JoshuaKGoldberg JoshuaKGoldberg added the good first issue Good for newcomers; welcome aboard! label May 9, 2020
@KingDarBoja
Copy link
Collaborator

@JoshuaKGoldberg I haven't found this rule equivalent on the eslint-plugin-react repo. I asked for some roadmap table which address the equivalents on this tslint-react issue.

@KingDarBoja KingDarBoja added status: blocked We can't make progress on this issue until something else is resolved... and removed status: accepting prs Please, send in a PR to resolve this! ✨ labels Aug 15, 2020
@KingDarBoja
Copy link
Collaborator

UPDATE This rule is being discussed at jsx-eslint/eslint-plugin-react#2735 which could make use of https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-max-props-per-line.md by setting maximum option to 1 for multiline declaration (which requires a PR at the linked issue).

Closing this for now while waiting for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! status: blocked We can't make progress on this issue until something else is resolved...
Projects
None yet
Development

No branches or pull requests

2 participants