fix(eslint-plugin): [method-signature-style] don't auto-fix interfaces within namespaces

[aggmoulik]

Fixes #2340

Signed-off-by: Moulik Aggarwal [email protected]

[typescript-eslint]

Thanks for the PR, @aggmoulik!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[aggmoulik]

Fixes #2340

[codecov]

Codecov Report

Merging #2678 into master will decrease coverage by 0.03%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
- Coverage   92.82%   92.79%   -0.04%     
==========================================
  Files         294      294              
  Lines        9670     9682      +12     
  Branches     2712     2717       +5     
==========================================
+ Hits         8976     8984       +8     
- Misses        328      330       +2     
- Partials      366      368       +2     

Flag	Coverage Δ
#unittest	92.79% <82.35%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts	89.02% <82.35%> (-3.84%)	⬇️

[bradzacher]

the logic itself LGTM - just two comments.
thanks for working on this!

[bradzacher]

We can remove the any here with the catch-all Node type

Suggested change

	function isNodeParentModuleDeclaration(node: any): boolean {
	if (node.parent?.type === AST_NODE_TYPES.TSModuleDeclaration) {
	return true;
	}
	if (node.parent?.type === AST_NODE_TYPES.Program) {
	return false;
	}
	return isNodeParentModuleDeclaration(node.parent);
	}
	function isNodeParentModuleDeclaration(node: TSESTree.Node): boolean {
	if (!node.parent) {
	return false;
	}
	if (node.parent.type === AST_NODE_TYPES.TSModuleDeclaration) {
	return true;
	}
	if (node.parent.type === AST_NODE_TYPES.Program) {
	return false;
	}
	return isNodeParentModuleDeclaration(node.parent);
	}

[bradzacher]

indent the example one line, and then you can use the fixer to auto-format the code block

Suggested change

	code: noFormat`
	declare global {
	namespace jest {
	interface Matchers<R, T> {
	// Add overloads specific to the DOM
	toHaveProp<K extends keyof DomPropsOf<T>>(name: K, value?: DomPropsOf<T>[K]): R;
	toHaveProps(props: Partial<DomPropsOf<T>>): R;
	}
	}
	}
	`,
	code: `
	declare global {
	namespace jest {
	interface Matchers<R, T> {
	// Add overloads specific to the DOM
	toHaveProp<K extends keyof DomPropsOf<T>>(name: K, value?: DomPropsOf<T>[K]): R;
	toHaveProps(props: Partial<DomPropsOf<T>>): R;
	}
	}
	}
	`,

[aggmoulik]

Hy @bradzacher , I have updated things you suggested.

[bradzacher]

LGTM - thanks for your contribution!

[aggmoulik]

Hy @bradzacher, Can you please add hacktoberfest-accepted label here.

[bradzacher]

I thought they only need a tag if they weren't going to be merged in October?