question: default value forbidUnknownValues

[aashutoshrathi]

I was trying to...
see if forbidUnknownValues is true by default in 0.14.0

The problem:
In docs it still says
Fails validation for objects unknown to class-validator. Defaults to false

[braaar]

Could you point to the exact file and line you are referring to? I can't seem to find what you are referring to.

[aashutoshrathi]

class-validator/src/validation/ValidatorOptions.ts

Line 75 in ceb5502

* Fails validation for objects unknown to class-validator. Defaults to false.

[braaar]

That is a past version of the source code from a year ago.

[aashutoshrathi]

which branch has the latest code?

[braaar]

develop. I'll consider this issue settled

[aashutoshrathi]

develop. I'll consider this issue settled

I might be completely wrong here, but isn't this the code from develop.

class-validator/src/validation/ValidatorOptions.ts

Lines 74 to 82 in 0b50d8d

	/**
	* Fails validation for objects unknown to class-validator. Defaults to false.
	*
	* For instance, since a plain empty object has no annotations used for validation:
	* - `validate({})` // passes
	* - `validate({}, { forbidUnknownValues: true })` // fails.
	* - `validate(new SomeAnnotatedEmptyClass(), { forbidUnknownValues: true })` // passes.
	*/
	forbidUnknownValues?: boolean;

And for the context, I'm just talking about doc strings.

Example here (using v0.14.0):

Thanks for actively replying and apologies for being PITA

[brnkes]

I noticed the same discrepancy. Seems like a typo ?

Changelog (0.14.0) implies that forbidUnknownValues is enabled by default & #1798 implements a true-by-default logic.

However, ValidatorOptions' JSDoc suggests otherwise. e252183 is the last commit for ValidatorOptions and it is also what the most recently published package (0.14.0) includes.

[braaar]

I stand corrected! This is indeed a typo.

[braaar]

PR welcome :)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.