Improve documentation of commonAssignmentCheck and correct overrides #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
requested changes
Dec 8, 2023
| @@ -172,15 +171,16 @@ protected boolean commonAssignmentCheck( | |||
| } | |||
|
|
|||
| @Override | |||
| @FormatMethod | |||
| @@ -101,14 +104,11 @@ protected boolean commonAssignmentCheck( | |||
| } | |||
|
|
|||
| if (isLessThan) { | |||
| // Print the messages because super isn't called. | |||
| * <p>Because this method is not called for all pseudo-assignments, subclasses should only | ||
| * override this, if the tree of the value expression is required; otherwise, override {@link | ||
| * #commonAssignmentCheck(AnnotatedTypeMirror, AnnotatedTypeMirror, Tree, String, Object...)}. If | ||
| * this method is overridden, then the first then should call {@link |
| * variableType} and emits an error message (through the compiler's messaging interface) if it is | ||
| * not valid. | ||
| * | ||
| * <p>Subclasses should override this method if in all cases unless the tree for the {@code |
| if (showchecks) { | ||
| TypeMirror exprTypeMirror = TreeUtils.typeOf(exprTree); | ||
| System.out.printf( | ||
| "%s %s (at %s): actual tree = %s %s%n expected: %s %s%n", |
There was a problem hiding this comment.
Why is this labeled "expected"? That doesn't seem to fit with shouldSkipUses(ExpressionTree).
|
@smillst A ping in case this fell through the cracks. It isn't urgent, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.