silent npm run

[iamstarkov]

why did you choose run npm scripts in silent? usually its hiding some problems

prepush: "npm run unexisting",

husky will fail, and you will have no idea what is a problem

[typicode]

Originally, it was to make hooks output less verbose and more readable:

$ npm run test
src/actions/daemon.js -> lib/actions/daemon.js
src/actions/servers.js -> lib/actions/servers.js
...

vs

$ npm run test

> [email protected] test /home/typicode/d/hotel
> npm run build && mocha && npm run standard 


> [email protected] build /home/typicode/d/hotel
> babel src --out-dir lib --copy-files --loose all

src/actions/daemon.js -> lib/actions/daemon.js
src/actions/servers.js -> lib/actions/servers.js
...

Though, I agree that it hides things.

But if you need to debug stuff, you can run npm run prepush and you'll get the full output. That's one of the cool thing of having them defined in package.scripts.

[iamstarkov]

I thought about it sometime, and ended up with thought that its nice to hide if everything is okay, but if it failed, then it will be better to show the error message. what do you think?

[scotthovestadt]

I thought about it sometime, and ended up with thought that its nice to hide if everything is okay, but if it failed, then it will be better to show the error message. what do you think?

+1

[iamstarkov]

@typicode any thoughts?

[typicode]

Sorry, forgot to reply. I'm currently on vacation with just my phone, will make a better/more detailed answer when I get back :)

[andrew-makarenko]

I found this behaviour confusing, so it would be great to add some note about this in the readme.
Smth like 'Hook scripts will be runned with --silent flag, so you wouldn't see any information passed to STDOUT by your script. If you need to debug your script, you can run it manually npm run prepush'

[typicode]

Sorry for the delay.

I've removed the --silent option and published v0.10.2. As suggested by @iamstarkov, things will be more explicit this way.

Thank you all for the feedbacks :)

[iamstarkov]

@typicode just saying "thanks for husky and your time" again =)

[pgom]

@typicode actually it would be great if the silent (or other) flag could be used as an option. What do you think?

[typicode]

I prefer to avoid adding options to keep it simple and I'm kind of satisfied with husky not being silent. Also I'm not sure what other flag could be added?

[lili21]

I think optional silent would be helpful. When I am using git hooks for linting source code, those lint errors would be enough.