New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up the JMH benchmarking workflow again, but in a safer manner #968

Closed

msridhar opened this issue Jun 4, 2024 · 0 comments · Fixed by #975

Collaborator

msridhar commented Jun 4, 2024

We cannot safely trigger the job off of an issue comment. I'm thinking we should instead trigger it when a pull request gets a particular label:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

This should limit who can run the job to anyone who has "triage" access to the repo:

https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels#applying-a-label

So it's a whitelist that we can easily control.

msridhar mentioned this issue

Reenable JMH benchmarking in a safer manner #975

Merged

msridhar closed this as completed in

ab5972a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment