Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serialization adapter retrieval by version #1066

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

nimakarimipour
Copy link
Contributor

@nimakarimipour nimakarimipour commented Nov 5, 2024

This PR prepares for #1063 by moving the initializeAdapter declaration from FixSerializationConfig to SerializationVersionAdapter. This change ensures that version-specific serializations are handled directly by SerializationVersionAdapter, which will simplify test modifications in #1063.

This transition also aligns with a clearer design, as SerializationVersionAdapter should be responsible for computing the appropriate adapter for each new version. This approach will help us maintain version updates within SerializationVersionAdapter while keeping FixSerializationConfig unchanged.

I'm uncertain if maintaining backward compatibility is necessary in the long term. If it's not needed, we can consider removing it in the future. For now, however, this PR is required to keep #1063 concise.

@msridhar msridhar enabled auto-merge (squash) November 5, 2024 04:33
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (e9541e3) to head (36930c0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ixserialization/adapters/SerializationAdapter.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1066   +/-   ##
=========================================
  Coverage     87.65%   87.66%           
  Complexity     2222     2222           
=========================================
  Files            85       86    +1     
  Lines          7269     7271    +2     
  Branches       1436     1436           
=========================================
+ Hits           6372     6374    +2     
  Misses          456      456           
  Partials        441      441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 17fc1ba into uber:master Nov 5, 2024
10 of 11 checks passed
@nimakarimipour nimakarimipour deleted the nimak/refactor-adapter branch November 5, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants