Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update not-started activities' scheduled time when reseting workflows #4214

Open
yycptt opened this issue May 21, 2021 · 0 comments
Open

Update not-started activities' scheduled time when reseting workflows #4214

yycptt opened this issue May 21, 2021 · 0 comments
Labels
good first issue Up for grab as first issue to contribute to Cadence project up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute

Comments

@yycptt
Copy link
Contributor

yycptt commented May 21, 2021

Is your feature request related to a problem? Please describe.
Currently when reseting workflows, if there's a scheduled but not started activity in the workflow, the scheduled time for that activity will remain unchanged in the new workflow created by the reset operation. Since the workflow is newly created, the activity scheduled time should also be updated otherwise the activity will timeout early after reset.

Proposed Solution
temporalio/temporal#1502

  • Note that the history event timestamp for ActivityTaskScheduled event can't be updated since it's persisted. But when describing the workflow, activity scheduled time is retrieved from mutable state, so it will have the updated time.
  • When reseting workflow, a new activity task will be created and pushed to matching with the new schedule, so even if the previous one expired, the new one can be used to start the activity.
  • Client side will use the time specified in the ScheduledTimeOfThisAttempt field which is the updated schedule time, not the one from history event.
  • Activity timeout timer task will check mutable state to see if an activity really need to be timed out when it's processed so it won't timeout the activity unexpectedly.

Additional context
Add any other context or screenshots about the feature request here.

@demirkayaender demirkayaender added up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute good first issue Up for grab as first issue to contribute to Cadence project labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grab as first issue to contribute to Cadence project up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Development

No branches or pull requests

2 participants