Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset should be allowed with pending childWF in current run, if current run is already closed #5030

Open
longquanzheng opened this issue Nov 19, 2022 · 0 comments
Open

Reset should be allowed with pending childWF in current run, if current run is already closed #5030

longquanzheng opened this issue Nov 19, 2022 · 0 comments
Labels
customer Feature asks from customer feature New feature

Comments

@longquanzheng
Copy link
Collaborator

longquanzheng commented Nov 19, 2022 •
edited
Loading

cadence/service/history/reset/resetter.go

Line 643 in 1a50671

Message: "Can not reset workflow with pending child workflows",

This is because child WF could get get closed after parent closed, and parent will not receive the children close signals.

So that after parent is closed for any reasons(terminate/timeout/fail/etc), this parent is never allowed to reset to anywhere because it has a pending childWFs in its mutableState forever as "deadlock condition"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer Feature asks from customer feature New feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibarrajo @longquanzheng