Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Cannot specify version v3.10.0-rc1 in prototool.yaml #512

Closed
alisonbelow opened this issue Oct 10, 2019 · 3 comments
Closed

Cannot specify version v3.10.0-rc1 in prototool.yaml #512

alisonbelow opened this issue Oct 10, 2019 · 3 comments
Labels
1.10 Issue will be released with v1.10 bug Something isn't working

Comments

@alisonbelow
Copy link

Prototool is unable to support version 3.10.0-rc1 specified in prototool.yaml file.

If the prototool.yaml file looks like:

protoc:
  version: 3.10.0-rc1

then the URL https://github.com/protocolbuffers/protobuf/releases/download/v3.10.0-rc1/protoc-3.10.0-rc1-osx-x86_64.zip is attempted to be used to download the appropriate zip file.

If the prototool.yaml file looks like:

protoc:
  version: 3.10.0-rc-1

then the URL https://github.com/protocolbuffers/protobuf/releases/download/v3.10.0-rc-1/protoc-3.10.0-rc-1-osx-x86_64.zip is attempted to be used to download the appropriate zip file.

The URL to download protoc version is https://github.com/protocolbuffers/protobuf/releases/download/v3.10.0-rc1/protoc-3.10.0-rc-1-osx-x86_32.zip. Notice the difference in .../v3.10.0-rc1/... and .../protoc-3.10.0-rc-1-osx-x86_32.zip. The hyphen location differs in the URL snippet and the zip file name, making it impossible to specify this protoc version in the prototool.yaml file.

@smaye81
Copy link
Contributor

smaye81 commented Oct 14, 2019

Yeah this is due to an anomaly in how the protoc download URL is formed. We can add additional parsing for release candidates to remove the - for the subdomain portion of the URL.

In the meantime, 3.10.0 is out so hopefully you are no longer blocked on this.

@smaye81
Copy link
Contributor

smaye81 commented Oct 15, 2019

This should be fixed by #515

@smaye81 smaye81 closed this as completed Oct 15, 2019
@smaye81 smaye81 added 1.10 Issue will be released with v1.10 bug Something isn't working labels Oct 15, 2019
@alisonbelow
Copy link
Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.10 Issue will be released with v1.10 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants