Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GTS use coreos matched kernel #1456

Merged
merged 21 commits into from
Jul 1, 2024
Merged

feat: GTS use coreos matched kernel #1456

merged 21 commits into from
Jul 1, 2024

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Jun 27, 2024

GTS will use the matched kernel of whatever is the current coreos version. Additionally, now uses the convenience tags instead of version numbers for determining which version of fedora to build. Stages having beta builds for F41. Deprecate aurora gts

GTS will use the matched kernel of whatever is the current coreos
version. Additionally, now uses the convenience tags instead of version
numbers for determining which version of fedora to build. Stages having
beta builds for F41.

feat: deprecate aurora gts

fix: remove bad formating

chore: more formatting fixes

fix: make reusuable build, build again

fix: remove unnecessary include
@m2Giles
Copy link
Member Author

m2Giles commented Jun 28, 2024

This is now green. Last bits are updating the just scripts and updating the README.md.

Our condition checks should move to

main, bluefin, gts
main, bluefin-dx, gts
nvidia, bluefin-dx, gts
main, aurora, stable
main,  aurora,-dx stable
nvidia, aurora-dx, stable
main, bluefin, stable
main, bluefin-dx, stable
nvidia, bluefin-dx, stable
main, bluefin, latest
main, aurora, latest

@m2Giles
Copy link
Member Author

m2Giles commented Jun 28, 2024

While Nvidia is being installed using the same method as bazzite/hwe a user is reporting an issue with driver mismatch.

@m2Giles
Copy link
Member Author

m2Giles commented Jun 29, 2024

Nvidia issue was due to an update in between akmods build and the image build.

@m2Giles m2Giles marked this pull request as ready for review June 30, 2024 14:17
@m2Giles m2Giles requested a review from castrojo as a code owner June 30, 2024 14:17
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Jun 30, 2024
@m2Giles m2Giles marked this pull request as draft June 30, 2024 14:17
@m2Giles m2Giles marked this pull request as ready for review June 30, 2024 14:51
fix: rollback helper use stable

fix: bluefin-cli only source and run commands if it exists and commands
are available
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2024
@m2Giles m2Giles added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 080802f Jul 1, 2024
39 of 44 checks passed
@m2Giles m2Giles deleted the gts-calc branch July 1, 2024 01:09
Copy link

@ethanjli ethanjli Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: in line 243 of this file (i.e. within the "$IS_COREOS" == "true" branch), there is no BUILD_TAGS+=("stable") line. Was this omission intentional?

In my fork of the bluefin repo (which is now just a layer of changes over Aurora) I found I had to add that line in my copy of the reusable-build-iso workflow - without it, the "Build Image" step errored out on pushes to the main branch, because the BUILD_TAGS array was empty there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants