Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable evdi #1605

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: disable evdi #1605

merged 1 commit into from
Aug 14, 2024

Conversation

castrojo
Copy link
Member

No description provided.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@castrojo castrojo merged commit 1e47fda into main Aug 14, 2024
54 checks passed
@castrojo castrojo deleted the evdi branch August 14, 2024 14:04
@MilesEdwards
Copy link

MilesEdwards commented Oct 2, 2024

Hey @castrojo, @p5,

I wanted to discuss this change as it's impacted day-to-day development.

Lesson learned: I will switch to a custom image to avoid this. Still, Bluefin's goal is to provide a seamless 'pick up and code' experience, but the EVDI module is regularly added and removed on a whim.

Would it be possible to commit to one of the following approaches for better consistency:

  1. Keep evdi baked in; users can remove/disable where unnecessary
    or
  2. Skip evdi: require users to add it themselves as needed

I'm partial to option 1, given it's easier to turn off a service

@MilesEdwards
Copy link

MilesEdwards commented Oct 2, 2024

@castrojo, able to share context? This PR was tagged as a fix, so was there some issue on your system caused by evdi, or an upcoming conflict?

@m2Giles
Copy link
Member

m2Giles commented Oct 2, 2024

Most of the back and forth you see is that the kmod breaks often. To not prevent builds we disable evdi.

Where things get tricky is that you cannot do an rpm-install for the kmod at run time. So if you want it you need to make a custom image. Displaylink is used in a ton of docks so we would like to include this for hardware enablement.

But yes overall it is a frustrating situation that this kmod breaks a lot. It has even more bizarre behavior as well.

@castrojo
Copy link
Member Author

castrojo commented Oct 2, 2024

Yeah sorry, not intentional on our part. Feels like we turn this thing on half of people's docks break, we turn it off the other half of people's docks break. And then the module may or may not build at that time. Additionally there's CPU usage issues depending on the dock being used, etc.

I personally do not own one of these so we are dependent on what people report. It might make sense for us to just explicitly say we don't support these. I cannot believe vendors sell this as a product. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants