Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fish): address overriden config #912

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

bayou-brogrammer
Copy link
Contributor

@bayou-brogrammer bayou-brogrammer commented Feb 16, 2024

This seemed like the easier route which is to move our fish functions into etc so they are not overridden when fish installs.

@m2Giles
Copy link
Member

m2Giles commented Feb 17, 2024

There appears to be no changes at all now?

@bayou-brogrammer
Copy link
Contributor Author

There appears to be no changes at all now?

its a file change from /usr to /etc/

@m2Giles
Copy link
Member

m2Giles commented Feb 17, 2024

There is a vendor directory as well. I was using that location for bluefin-cli.

My only concerns with /etc is that we lose out on image changes if they make any local changes in /etc

@castrojo castrojo merged commit 614ada6 into ublue-os:main Feb 17, 2024
29 checks passed
@bayou-brogrammer bayou-brogrammer deleted the fish-fix branch February 19, 2024 02:20
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants