Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nitpick] spinner: change/update the look #4132

Open
Muqtxdir opened this issue Sep 8, 2024 · 10 comments · May be fixed by #4134
Open

[nitpick] spinner: change/update the look #4132

Muqtxdir opened this issue Sep 8, 2024 · 10 comments · May be fixed by #4134

Comments

@Muqtxdir
Copy link
Member

Muqtxdir commented Sep 8, 2024

hi,

the spinner/process-working is the only symbolic icon in the scalable group that is not 1px and very busy/noisy at lower sizes.
does it make sense to swap the spinner to vanilla-framework's spinner ?

current proposal
Screencast from 2024-09-09 01-05-49 Screencast from 2024-09-09 01-06-10
@Feichtmeier
Copy link
Member

optimal would be what we have in flutter
but I agree the right thing is def. less noisy and cleaner
lets wait for the other crew 👴 👴 👴 👴 👴

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Sep 9, 2024

@Jupi007 and @ubuntujaggers wdyt?

@Jupi007
Copy link
Member

Jupi007 commented Sep 9, 2024

This spinner icon has always annoyed me tbh. The problem is that we can't use a gradient here... which means we can't use the same design as yaru flutter 😕

So... I don't have a strong opinion on this, maybe I can do something nice in flutter using @Muqtxdir proposal

@Muqtxdir Muqtxdir linked a pull request Sep 9, 2024 that will close this issue
4 tasks
@3v1n0
Copy link
Contributor

3v1n0 commented Sep 10, 2024

It's a nice version, maybe not yet for this release though.

Anyways, I think the flutter spinner should totally be in sync with what we've in yaru gtk/shell (and not orange).

@Jupi007
Copy link
Member

Jupi007 commented Sep 10, 2024

If we change the spinner design, we also need to update plymouth's one.

@Muqtxdir
Copy link
Member Author

sure @Jupi007 ican handle plymouth component as well for the next release

@Jupi007
Copy link
Member

Jupi007 commented Sep 10, 2024

Great, on my side I'll try to create something nice for Flutter :)

@ochi12
Copy link
Contributor

ochi12 commented Nov 17, 2024

@Muqtxdir where do you do this animations?

@ochi12
Copy link
Contributor

ochi12 commented Nov 17, 2024

hi,

the spinner/process-working is the only symbolic icon in the scalable group that is not 1px and very busy/noisy at lower sizes. does it make sense to swap the spinner to vanilla-framework's spinner ?

I think 2px is a better choice tho. I will try it out once i learn how you animate.

@Jupi007
Copy link
Member

Jupi007 commented Nov 17, 2024

@ochi12 this is just a simple symbolic icon located into scalable-max-32, gtk just rotate it.
But for the cursor, you need to create each frames manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants