-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsigned Fixed Point #1
Comments
Having unsigned FixedPoints should be doable without too many problems, but making them work together with signed FixedPoints (ie. in places like inside Muxes) might be a challenge. I support the idea of having both signed and unsigned FixedPoint types in Chisel. However, from a library standpoint, one needs to be careful when adding new things to the public API. For now, we have recreated Chisel's original FixedPoint interface, which supported only signed fixed-point data. I want to consult with Chisel developers about the best way to have an API that supports both signed and unsigned FixedPoints before proceeding to implement it. There might also be implementation challenges related to having two different fixed-point types that we're not yet aware of, that—if even possible to implement—may require additional work-arounds due to the current limitations of Chisel's public API for adding new types. In any case, I will take the usigned fixed-point interface discussion to this issue. As you can see, another person has also recently expressed interest in having an unsigned fixed-point type. In the meanwhile, if you need unsigned FixedPoints in your project, you can do the following:
In the future we may create a generic fixed-point base class from which the current |
I need an unsigned fixed point data type for a design I am working on. I had a look at the class in question and it seems as though it might be possible to have the class take a generic for the inner data type. However, it seems as though the class uses the
AsSInt
function. I didn't see any untyped versions of this function.Please note that I am relatively new to Chisel and Scala, so I might have missed something important.
Do you think it would be feasible to parameterize the FixedPoint class to be either signed or unsigned? Or perhaps there is already a workaround to this issue?
The text was updated successfully, but these errors were encountered: