Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanner Checker Fails when not activated. #17

Closed
nimakarimipour opened this issue Jul 13, 2022 · 0 comments · Fixed by #18 or #19
Closed

Scanner Checker Fails when not activated. #17

nimakarimipour opened this issue Jul 13, 2022 · 0 comments · Fixed by #18 or #19
Labels
bug Something isn't working

Comments

@nimakarimipour
Copy link
Member

Describe the bug
Scanner checker throws null-pointer-exception when the checker is not activated.

To Reproduce
Steps to reproduce the behavior:

  1. Build the project when the config file is not passed as error prone flag.

Expected behavior
When the config file is not passed, the checker should not terminate with exception, instead it should silently quit from every method.
@nimakarimipour nimakarimipour mentioned this issue Jul 13, 2022
Merged
@nimakarimipour nimakarimipour added the bug Something isn't working label Jul 14, 2022
nimakarimipour added a commit that referenced this issue Jul 14, 2022
@nimakarimipour
fix #17
3ffd252
@nimakarimipour nimakarimipour mentioned this issue Jul 14, 2022
Merged
nimakarimipour added a commit that referenced this issue Jul 14, 2022
@nimakarimipour
Merge pull request #18 from nimakarimipour/nimak/issue17
aea37b6 
Fix #17
@nimakarimipour nimakarimipour mentioned this issue Jul 14, 2022
Merged
nimakarimipour added a commit that referenced this issue Jul 19, 2022
@nimakarimipour
Merge pull request #19 from nimakarimipour/nimak/add-gaurd-configpath
aa37cdb 
This PR is a follow up to GH-18 and resolves #17. With this PR, an exception will be thrown at the time a wrong configuration for the Scanner checker (null value for Output or ConfigPath) and will prevent propagation of null value through the program.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@nimakarimipour