fix: caption text area korean ime issue #3799
Merged
+64
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn typecheck
yarn lint:fix
yarn test
yarn brl
yarn changeset
hello. When using Caption, there was an issue where each Korean character was cut off when entering Korean characters. A video is attached for explanation.
I thought it was an IME issue and modified the code.
And the result is as shown in the video below.
I didn't know how to test the plate example within the package, so I brought the source locally, modified it, and checked its operation.
I am willing to continue contributing to your project. It would be good if the contributing guidelines included guidelines on how to test immediately after changing a component or plugin.
If you don't like the source code, you can modify it at will.