Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caption text area korean ime issue #3799

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: caption text area korean ime issue #3799

merged 2 commits into from
Nov 22, 2024

Conversation

siosio34
Copy link
Contributor

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

hello. When using Caption, there was an issue where each Korean character was cut off when entering Korean characters. A video is attached for explanation.

화면 기록 2024-11-22 오후 7 36 44

I thought it was an IME issue and modified the code.

And the result is as shown in the video below.

화면 기록 2024-11-22 오후 7 40 16

I didn't know how to test the plate example within the package, so I brought the source locally, modified it, and checked its operation.

I am willing to continue contributing to your project. It would be good if the contributing guidelines included guidelines on how to test immediately after changing a component or plugin.

If you don't like the source code, you can modify it at will.

Copy link

codesandbox bot commented Nov 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 3861e69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@udecode/plate-caption Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:06am

@zbeyens
Copy link
Member

zbeyens commented Nov 22, 2024

Thanks for contributing @siosio34. We don't have strict guidelines so you can continue that way. Maybe just add a changeset for each PR, using yarn changeset. When modifying a package, run yarn build:watch in that package to see the changes in the docs (yarn dev).

You can DM me on Discord if you need any help!

@zbeyens zbeyens merged commit 846d5ec into udecode:main Nov 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants