New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime config should be put in config/runtime.exs? #87

Open

kayuapi opened this issue Nov 9, 2021 · 1 comment

kayuapi commented Nov 9, 2021

Hi all,

currently the guide shows that we configure the runtime environment like this: https://github.com/ueberauth/ueberauth_google/blob/master/README.md#installation

Use that if you want to read client ID/secret from the environment variables in the run time:

config :ueberauth, Ueberauth.Strategy.Google.OAuth,
client_id: {System, :get_env, ["GOOGLE_CLIENT_ID"]},
client_secret: {System, :get_env, ["GOOGLE_CLIENT_SECRET"]}

Should we put the config in config/runtime.exs like the following:

config :ueberauth, Ueberauth.Strategy.Google.OAuth,
client_id: System.get_env("GOOGLE_CLIENT_ID"),
client_secret: System.get_env("GOOGLE_CLIENT_SECRET")

Member

yordis commented Nov 9, 2021

PR welcome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment