Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdi5 ts init adds wrong ui5 type devDependency #11

Open
heimwege opened this issue May 8, 2024 · 2 comments
Open

wdi5 ts init adds wrong ui5 type devDependency #11

heimwege opened this issue May 8, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@heimwege
Copy link

heimwege commented May 8, 2024

Moved ui5-community/wdi5#610 from wdi5 repo to wdi5-create

Describe the bug
The easy ui5 generator includes a sub-generator that handles the wdi5 integration into the generated app. This mostly consists of npm init wdi5 -- --ts. Init wdi5 seems to hard coded introduce a devDependency to the latest version of @openui5/types. But in the context of the easy ui5 generator the user can select between sapui5 and openui5 and also which specific version to be used.

See also my initial issue for the ui5 ts app generator: ui5-community/generator-ui5-ts-app#33

I think this is caused here: https://github.com/ui5-community/create-wdi5/blob/main/src%2Findex.ts#L20

UPDATA: and the tsconfig also contains the @openui5/types type: https://github.com/ui5-community/create-wdi5/blob/main/templates/test/tsconfig.json#L4

To Reproduce
yo easy-ui5 -> select generator ts-app and follow the instructions. select sapui5 (e.g. 1.120.11) and have a look at the package.json afterwards.

Expected behavior
Depending on the selection in the easy ui5 generator either @openui5/types or @sapui5/types should be included as devDependency in the version entered in the respective generator step.

@vobu vobu added the bug Something isn't working label May 8, 2024
@vobu
Copy link
Contributor

vobu commented May 8, 2024

ACK. will take a moment until we got this though. Help, anyone?!

@heimwege
Copy link
Author

Some more context: Here's the place where create-wdi5 is being used as a nested generator in the ts-app generator and where it is run in the easy ui5 generator, but I have no clue how properties of the parent generator can be accessed from the sub generator or if they need to be added to the yeoman env first and basically how all this yeoman generator stuff works 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants