Skip to content

Commit

Permalink
fix: ui5 plugin generation failing (#6)
Browse files Browse the repository at this point in the history
* Migrated package json to new versions

* change test module

* Added latest code for generate FLP Plugin removed unwanted code

* Pre commit rules added

* removed local file

* fixed flp start

* prepare command modified

* Update main.yml

* Updated node version of working & setup node

* Fixed review comments

Fixes #5 

---------

Co-authored-by: Amar Ubhe <[email protected]>
Co-authored-by: Amar Ubhe <i545363>
  • Loading branch information
ubheamar and Amar Ubhe authored Nov 1, 2024
1 parent a73826b commit 8976d0d
Show file tree
Hide file tree
Showing 56 changed files with 10,612 additions and 1,051 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ jobs:
node: [0, 1, 2, 3]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
registry-url: https://registry.npmjs.org/

- run: git config --global user.email "[email protected]" && git config --global user.name "Your Name"
Expand Down
16 changes: 14 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# Hidden Files
_
test/*/

# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Dependency directories
node_modules/
yarn.lock
package-lock.json

.DS_Store
1 change: 1 addition & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npm run hooks:pre-commit
5 changes: 5 additions & 0 deletions .husky/skip.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
if (process.env.HUSKY_SKIP || process.env.NODE_ENV === "production") {
process.exit(0);
} else {
process.exit(1);
}
3 changes: 3 additions & 0 deletions .lintstagedrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"*.js": "eslint"
}
7 changes: 6 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
generators/newwebapp/templates/uimodule/ui5.yaml
# Ignore test files
test/*/

# Ignore all source files using the placeholders to kill the syntax
generators/app/templates/webapp/Component.js
generators/app/templates/webapp/test/*
60 changes: 7 additions & 53 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# Generator for SAPUI5 Fiori Launchpad Plugin

> Generator for UI5 Fiori Launchpad Plugin using UI5 Tooling. (based on the [Easy UI5 Generator](https://github.com/SAP/generator-easy-ui5))
> Includes
> - Fiori Launchpad Plugin Component
> - Shell Extension Code Samples
> - Opa5 Test enabled
>
> - Fiori Launchpad Plugin Component
> - Shell Extension Code Samples
> - Opa5 Test enabled
## Usage with easy-ui5

Expand Down Expand Up @@ -43,60 +45,12 @@ $> yo ./generator-ui5-project
´ ` |° ´ Y `
```
## Target platforms
During the prompting phase, the generator will ask on which target platform your app should run. Currently, the following options are available:
### Static webserver
This is the most basic option. Choose this option if you want to deploy the web app in your custom environment or host it on an arbitrary server.
### SAP Launchpad service
Use this option if you would like to develop a Fiori Launchpad application that should run on Cloud Foundry. The generator will install a module that adds Fiori Launchpad resources to the HTML5 application repository.
### SAP NetWeaver
Use this option if you want to deploy your application(s) to the SAP NetWeaver ABAP Repository.
## Test Application
```bash
npm run test
```
## Deployment
Depending on your target platform you'll need to install additional tools:
### Cloud Foundry
Required tools:
1. [Create a free account](https://developers.sap.com/mena/tutorials/hcp-create-trial-account.html) on SAP BTP Trial
2. [Install](https://developers.sap.com/tutorials/cp-cf-download-cli.html) the Cloud Foundry Command Line Interface
```sh
cf login
```
3. [Install](https://github.com/cloudfoundry-incubator/multiapps-cli-plugin) the MultiApps CF CLI Plugin
Deployment steps:
Call this command from the root directory to deploy the application to Cloud Foundry
```
npm run deploy
```
### SAP NetWeaver
Deployment steps:
Update the ui5.yaml file with your system settings (user, password & server) and ABAP repository settings (package, BSP Container & Transport).
Run following command to deploy the application to SAP NetWeaver
```
npm run deploy
```
## Support
Please use the GitHub bug tracking system to post questions, bug reports or to create pull requests.
Please use the GitHub bug tracking system to post questions, bug reports or to create pull requests.
34 changes: 34 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import globals from "globals";
import js from "@eslint/js";
import jsdoc from "eslint-plugin-jsdoc";

export default [
js.configs.recommended,
jsdoc.configs["flat/recommended"],
{
languageOptions: {
globals: {
...globals.node
},
ecmaVersion: 2023,
sourceType: "module"
},
rules: {
"no-unused-vars": "warn"
}
},
{
ignores: [
"eslint.config.js",

// Ignore node_files
"node_modules/",

// Ignore templates
"generators/*/templates/",

// Ignore test files
"test/"
]
}
];
194 changes: 0 additions & 194 deletions generators/additionalmodules/index.js

This file was deleted.

13 changes: 0 additions & 13 deletions generators/additionalmodules/templates/approuter/package.json

This file was deleted.

3 changes: 0 additions & 3 deletions generators/additionalmodules/templates/deployer/readme.md

This file was deleted.

18 changes: 0 additions & 18 deletions generators/additionalmodules/templates/xs-security.json

This file was deleted.

Loading

0 comments on commit 8976d0d

Please sign in to comment.