Skip to content

Commit

Permalink
Fixed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ubheamar committed Sep 18, 2024
1 parent c3eff3d commit b7cf248
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 56 deletions.
60 changes: 7 additions & 53 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# Generator for SAPUI5 Fiori Launchpad Plugin

> Generator for UI5 Fiori Launchpad Plugin using UI5 Tooling. (based on the [Easy UI5 Generator](https://github.com/SAP/generator-easy-ui5))
> Includes
> - Fiori Launchpad Plugin Component
> - Shell Extension Code Samples
> - Opa5 Test enabled
>
> - Fiori Launchpad Plugin Component
> - Shell Extension Code Samples
> - Opa5 Test enabled
## Usage with easy-ui5

Expand Down Expand Up @@ -43,60 +45,12 @@ $> yo ./generator-ui5-project
´ ` |° ´ Y `
```
## Target platforms
During the prompting phase, the generator will ask on which target platform your app should run. Currently, the following options are available:
### Static webserver
This is the most basic option. Choose this option if you want to deploy the web app in your custom environment or host it on an arbitrary server.
### SAP Launchpad service
Use this option if you would like to develop a Fiori Launchpad application that should run on Cloud Foundry. The generator will install a module that adds Fiori Launchpad resources to the HTML5 application repository.
### SAP NetWeaver
Use this option if you want to deploy your application(s) to the SAP NetWeaver ABAP Repository.
## Test Application
```bash
npm run test
```
## Deployment
Depending on your target platform you'll need to install additional tools:
### Cloud Foundry
Required tools:
1. [Create a free account](https://developers.sap.com/mena/tutorials/hcp-create-trial-account.html) on SAP BTP Trial
2. [Install](https://developers.sap.com/tutorials/cp-cf-download-cli.html) the Cloud Foundry Command Line Interface
```sh
cf login
```
3. [Install](https://github.com/cloudfoundry-incubator/multiapps-cli-plugin) the MultiApps CF CLI Plugin
Deployment steps:
Call this command from the root directory to deploy the application to Cloud Foundry
```
npm run deploy
```
### SAP NetWeaver
Deployment steps:
Update the ui5.yaml file with your system settings (user, password & server) and ABAP repository settings (package, BSP Container & Transport).
Run following command to deploy the application to SAP NetWeaver
```
npm run deploy
```
## Support
Please use the GitHub bug tracking system to post questions, bug reports or to create pull requests.
Please use the GitHub bug tracking system to post questions, bug reports or to create pull requests.
2 changes: 1 addition & 1 deletion generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export default class extends Generator {
{
type: "input",
name: "author",
message: "Who is the author of the application?",
message: "Who is the author of the FLP Plugin?",
default: this.user.git.name()
},
{
Expand Down
4 changes: 2 additions & 2 deletions generators/app/templates/readme.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# UI5 Application <%= namespace %>
# UI5 FLP Plugin <%= namespace %>

Insert the purpose of this project and some interesting info here...

## Description

This app demonstrates a setup for developing UI5 applications.
This app demonstrates a setup for developing FLP Plugin.

## Requirements

Expand Down

0 comments on commit b7cf248

Please sign in to comment.