Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: preview-middleware #35

Open
heimwege opened this issue May 31, 2024 · 2 comments
Open

feature request: preview-middleware #35

heimwege opened this issue May 31, 2024 · 2 comments
Labels
blocked Issue is currently blocked enhancement New feature or request

Comments

@heimwege
Copy link

Hi guys,

how about using the preview middleware to get rid of the test glue code?

Using this config in the ui5*.yaml (further configuration w.r.t paths, testfile name patterns, etc. is possible)

  - name: preview-middleware
    afterMiddleware: compression
    configuration:
      test:
        - framework: QUnit
        - framework: OPA5
        - framework: Testsuite

makes the following files superfluous:

  • /test/testsuite.qunit.html
  • /test/testsuite.qunit.js
  • /integration/opaTests.qunit.html
  • /integration/opaTests.qunit.js
  • /unit/unitTests.qunit.html
  • /unit/unitTests.qunit.js

Having this glue code centrally managed could be quite helpful in case the test recommended setup changes (e.g. because resources/sap/ui/test/starter/createSuite.js should be used).

Using this middleware might not only be relevant for the ts app generator but for other generators as well.

@petermuessig
Copy link
Member

petermuessig commented Sep 10, 2024

We are currently reworking the test started code. Till then, I would prefer not to integrate the preview-middleware into the "basic" templates of UI5 applications.

Let's keep this issue open for the future evolution of the templates.

@petermuessig petermuessig added enhancement New feature or request blocked Issue is currently blocked labels Sep 10, 2024
@tobiasqueck
Copy link

We are currently reworking the test started code. Till then, I would prefer not to integrate the preview-middleware into the "basic" templates of UI5 applications.

Let's keep this issue open for the future evolution of the templates.

The middleware removes that from the project, so wouldn't it be good then to integrate it now? And, once, you have new guidance for the test starter code, then we would implement it in the middleware and all projects "magically" use it once upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue is currently blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants