Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compatible with esm less plugins #1162

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented May 14, 2024

兼容 esm 导出的 less 插件

Summary by CodeRabbit

  • 优化
    • 优化了插件实例化的方式,现在在创建插件类的实例之前,代码会检查所需模块中是否有默认导出。
    • 更改了导出或公共实体的声明。

@PeachScript PeachScript requested a review from xusd320 May 14, 2024 09:38
Copy link
Contributor

coderabbitai bot commented May 14, 2024

摘要变更

packages/mako/src/lessLoader/lessLoader.worker.ts: ## 摘要

在位于packages/mako/src/lessLoaderlessLoader.worker.ts文件中,修改了插件实例化的方式。现在代码在创建插件类实例之前会检查所需模块中是否有默认导出。

导出或公共实体的声明变更

  • const pluginClass = require(p[0]);const pluginModule = require(p[0]);
  • return new pluginClass(p[1]);const PluginClass = pluginModule.default || pluginModule; return new PluginClass(p[1]);

指导

  • 漫游:对整体变更的高层摘要,不涉及特定文件,限制在80字内。
  • 变更:文件及其变更摘要的Markdown表格。将具有相似变更的文件分组到同一行中,以节省空间。使用省略号缩短过长的路径部分。

诗歌

代码变更如诗行,兔子欢歌不停跳,插件实例化有新规则,技术舞台展新貌。 🐇📜

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xusd320 xusd320 merged commit a7ce038 into master May 14, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the PeachScript-patch-1 branch May 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants