-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add watch.ignorePaths config #1179
Conversation
概述更改Walkthrough整体变更概述:在多个文件中,添加了关于文件监视的新配置选项,包括忽略特定路径的设置。 Changes
Poem
Note Pull Request Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* feat: ✨ add [d]ynamic [r]equire runtime function * refactor: 🎨 dynamic import require process with interop * test: ✅ add test case * test: ✅ import context module adjust to dynamic import * release: @umijs/[email protected] * chore: ⬆️ mako 0.4.18-canary.20240517.1 * chore: ⬆️ update pnpm-lock * typo * fix: fix "too many files open" error when watching with-antd example (#1022) * fix: fix "too many files open" error when watching with-antd example * fix: include dist dictionary of root's parent dictionary when watching --------- Co-authored-by: zp365238 <[email protected]> Co-authored-by: pshu <[email protected]> * chore: 🔧 adjust puffin for easy profile for both long time compiling and watch mode (#1168) * chore: 🔧 adjust puffin for easy profile for long time compiling * refactor: 🎨 move profile logic to profile app * fix: decorator visitor should run before preset env (#1176) * test: ✅ add runtime assert in decorator and target to chrome 40 * fix: 🐛 move decorator before preset_env * add comment on decorators * feat: add watch.ignorePaths config (#1179) * release: @umijs/[email protected] * chore: ⬆️ v0.4.18-canary.20240520.1 * chore: ⬆️ update pnpm-lock --------- Co-authored-by: zhangpanweb <[email protected]> Co-authored-by: zp365238 <[email protected]> Co-authored-by: chencheng (云谦) <[email protected]>
背景
dumi 的场景,
在 root 启,然后 foo/node_modules 也进了 watch,并且其中有目录之间因为 link 导致的循环依赖,报错如下。
尝试的解法
当前解
提供额外配置项,但缺点是需要用户感知。
可能的其他解
把 watch 挪到 node 层实现。
Summary by CodeRabbit
新功能
BuildParams
结构体中添加了一个新字段watch
,其中包括一个可选的ignoredPaths
字符串数组。Config
结构体现在包括一个WatchConfig
类型的watch
字段,以及现有字段。mako.config.json
文件中添加了一个新的watch
配置选项,包括ignorePaths
设置。packages/mako/binding.d.ts
文件中的BuildParams
接口中添加了一个新的watch
属性,其中包括一个可选的ignoredPaths
字符串数组。文档
docs/config.md
文件中添加了一个新的配置选项watch
,具体为ignorePaths
。