-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(concatenate): exports conflict between root and inner #1256
Conversation
Walkthrough这次改动集中在优化模块拼接和导出实体声明的更新。新增了一些字段和函数以支持模块拼接功能,并调整了导出实体声明以适应这些变化。 Changes
Poem
Note Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,验证业务项目可以工作
* test: ✅ export conflict between root exports, inner exports and ext exports * fix(concatenate): 🐛 fix exports conflict in root inner and ext * refactor: 🎨 add runtime by utils
运行时保护,避免 export 冲突
对齐 webpack 处理,root 导出优先
close #1255
Summary by CodeRabbit
RootTransformer
中的define_exports
变量赋值,从__mako_require__.e
更改为__mako_require__.es
。runtime_code
函数中添加了concatenate_enabled
字段,指示模块串联是否启用。AppRuntimeTemplate
结构体添加了concatenate_enabled
公共布尔字段。app_runtime.stpl
的createRuntime
函数中增加了Export Star
实用函数requireModule.es
。ext.js
中引入了常量ext
和value
的导出,以及默认导出"ext-default"
。inner.js
中引入了导出常量value
、notConflict
和默认导出"inner-default"
。mako.config.json
引入了与项目优化相关的配置设置,指定了入口点和与模块处理相关的优化选项。root.js
中引入了来自inner.js
、ext.js
的导出,并定义了常量value
。