refactor: change the way of checking variable has been declared #897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
写了一个对比的
visitor
,让所有的 module 都跑 这个visitor
,visitor
有两个版本,一个用collect_decls
,一个用unresolved_mark
判定。用normal
的 example 来跑 puffin(yuyanAssets 跑了会栈溢出,examples/normal
已能看出差异) 。如下collect_decls
版本:puffin stat 如下
unresolved_mark
版本puffin stat 如下
结论:unresolved_mark 有明显优势 ,pr 把代码中通过
collect_decls bindings
的判定方式都改为使用unresolved_mark
的方式