Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes pop-up improvements #1019

Open
8 tasks
thomaspiller opened this issue Oct 10, 2024 · 3 comments
Open
8 tasks

Attributes pop-up improvements #1019

thomaspiller opened this issue Oct 10, 2024 · 3 comments

Comments

@thomaspiller
Copy link
Collaborator

thomaspiller commented Oct 10, 2024

It is planned to refactor the pop-up taking into account the specifications listed below. The attributes of the clicked features will be displayed in a table format allowing a better visualization of the data. Filters by value will be preserved.

Here is a prototype of what is planned to be developed: https://fxi.io/demo_table_attribute/


Initial post

The user experience of the pop-up could be improved by implementing the following changes (based on user feedback, in priority order):

  • Add a button to expand/collapse the list of attributes at the top of the pop-up. By default, only the main attribute is visible (current behavior). (Priority 1)
  • The layout of the pop-up could be optimized to be more compact so that more information can be visible at the same time. (P1)
  • Add a mechanism to highlight linked values ​​(i.e., when one or more values ​​are clicked/selected, all values ​​of the features linked to them are highlighted). (P1)
  • The size of the values ​​should be optimized according to the available space. The current width is too narrow in most cases to view the values ​​clearly. This is especially true when viewing the data of a single feature. (P1)
    image
  • Add a mechanism to preserve the state (expand/collapse) chosen by the user during their session. (P2)
  • A search tool could be added to filter the pop-up content by keyword (title attributes and values). (P2)
  • The pop-up state (position & open attributes) should be preserved when another feature is clicked in the map. This will allow to compare values ​​between features without having to make any click or scroll in the pop-up. (P2)
  • A toolbar (hamburger button) could be added to include all the tools/options of the pop-up and thus save some space in the UI. (P2)
@thomaspiller thomaspiller moved this to Todo - code base 📚 in MapX Planner Oct 10, 2024
@fxi
Copy link
Member

fxi commented Oct 16, 2024

The pop-up state (position & open attributes) should not be reset when a click is made in the map. This will allow to compare values ​​between features without having to make any click or scroll in the pop-up.

It looks like you want to accumulate and aggregate results from potentially totally different features sets. Keep in mind that this tools already aggregate overlapping features values(see bellow), and handle most WMS queryFeatures returned values.

Image

Two options for this :

  • A checkbox that says "Aggregate mode" / "Normal mode"
  • A key press. E.g. Ctrl + Click that accumulate result, and when released, display the widget.

Both cases require a medium refactor of this tool, for covering all possible cases, and handle merging results. The second option seems simpler, as it could be handled upstream – before building the widget.

Another idea :

  • A separate tool to query feature and show a marker on the map and a single value

@PierreLacroix
Copy link
Collaborator

PierreLacroix commented Dec 2, 2024

If I understand @thomaspiller's proposal correctly, the idea is not to aggregate or accumulate the results of different features, but rather the following:

  • First click on Feature1 in the layer: display the attributes of Feature1.
  • If the second click is on Feature2 in the layer, display the attributes of Feature2 instead of those of Feature1 (this is the current behavior).
  • If the second click is on an empty area of the map, keep the attributes of Feature1 displayed (currently, nothing is shown in this case). This way, we can more easily compare the attribute values of Feature1 and Feature2 since we have them in mind.

Objectively, I am fine with both behaviors.
Adding a normal/aggregation mode would be too complex for users, and adding a separate tool would complicate the user experience.

Otherwise, I approve of requests number 1 (very important) and 3:

  • Add a button to collapse/expand the list of attributes. By default, the list should be expanded so that all values are visible.
  • The size of the values should be optimized according to the available space. The current width is too narrow in most cases to view the values clearly, especially when viewing the data for a single feature.

@antobenve
Copy link
Collaborator

In my opinion, number 2 is the most important feature.

  • It helps to compare different features that are clicked at different times by focusing on one (or more) attributes which will be kept open and visible when the user changes feature.

attributes_dashboard

If this is too complex to have systematically, is there a way to have this behavior at least when the clicked layers do not change between two consecutive clicks? [e.g. t: 0, clicked layers A; t: 1, clicked layers: A]. [e.g. t: 0, clicked layers A, B; t: 1, clicked layers: A, B]

Number 3 is also cool to have.

@thomaspiller thomaspiller moved this from Requires feedback/discussion 🕸 to Todo - code base 📚 in MapX Planner Dec 5, 2024
@PierreLacroix PierreLacroix moved this from Todo - code base 📚 to Requires feedback/discussion 🕸 in MapX Planner Dec 16, 2024
@PierreLacroix PierreLacroix moved this from Requires feedback/discussion 🕸 to Todo - code base 📚 in MapX Planner Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo - code base 📚
Development

No branches or pull requests

4 participants