Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase width and height of the chrome extension's popup #3018

Open
1 task
parademovie opened this issue Sep 5, 2024 · 1 comment
Open
1 task

Increase width and height of the chrome extension's popup #3018

parademovie opened this issue Sep 5, 2024 · 1 comment

Comments

@parademovie
Copy link

parademovie commented Sep 5, 2024

Description

Increase the width and height of the chrome extension's popup page

Who's implementing?

  • I'm willing to implement this feature myself

The problem

Currently in the source code of Chromium, there is a piece of code about the width and height of the popup page for chrome extensions.
But this part of the code is the hard code and cannot be changed.
static constexpr gfx::Size kMaxSize = {800, 600};

refer to this link.

  // The min/max height of popups.
  // The minimum is just a little larger than the size of the button itself.
  // The maximum is an arbitrary number and should be smaller than most screens.
  static constexpr gfx::Size kMinSize = {25, 25};
  static constexpr gfx::Size kMaxSize = {800, 600};

Another reference :
https://stackoverflow.com/q/74963536
https://stackoverflow.com/q/8983165

Possible solutions

Hope that the Ungoogled-Chromium team can make this part of the code kMaxSize larger, such as {3000, 2000} or {1600, 1000} .
Or provide a option for users to customize, or delete this line.

Because current resolution of 4k monitors is 3840 × 2160 or 4096 × 2160. With the development of the times, the resolution of the display is also increasing, so in order to match today's display resolution, hope to modify this part of the code.

Or through other methods, the ultimate goal is to increase the size of the popup window when using the Chrome extension.

Thank you!

Alternatives

No response

Additional context

No response

@tomasz1986
Copy link

This code is problematic. It doesn't seem to take into account the screen size at all. For example, if you open it on a smaller screen, then it will end up being cut off at the bottom, making the "Manage Extensions" button disappear. I've experienced this on 8" and 10" tablets running Windows 10. I assume that if you increase the max size to something larger than the current 800x600, even more content will end up being cut off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants