Support additional API on Python 3 bindings #2016
Conversation
| def reg_write(self, reg_id: int, value) -> None: | ||
| # select register class for special cases | ||
| reg_cls = UcAArch32.__select_reg_class(reg_id) | ||
| assert check_maxbits(coproc, 4) |
There was a problem hiding this comment.
Why not make cpr_read/write raise an UC_ERR_ARG? Terminating the whole process without a chance to catch seems too aggressive.
There was a problem hiding this comment.
Generally speaking, exceptions are thrown when the arguments normally make sense but there is a specific problem this time (e.g. opening a file which happens to be inaccessible, etc.). In these cases the user may catch the exception and choose how to handle it.
Here the assertions come to block an invalid usage with incorrect arguments: it is not a call that may sometimes work and sometimes not -- rather it is invalid. There is no way to "handle" such case other than re-writing that piece of code.
There was a problem hiding this comment.
Okay, I also forget AssertionError can be caught so let it go.
|
|
||
| def msr_read(self, msr_id: int) -> int: | ||
| return self._reg_read(const.UC_X86_REG_MSR, UcRegMSR, msr_id) | ||
| return self.reg_read(const.UC_X86_REG_MSR, msr_id) | ||
|
|
||
| def msr_write(self, msr_id: int, value: int) -> None: |
There was a problem hiding this comment.
This seems the same as above, which should raise an exception, but maybe next time.
There was a problem hiding this comment.
I am not following on this one. What should raise an exception? It marks this line:
return self.reg_read(const.UC_X86_REG_MSR, msr_id)
* Styling and commets fixes * Add errno API support * Improve OOP approach by adjusting the way reg types are selected * Leverage new approach to deduplicate reg_read and reg_write code * Adjust reg_read_batch * Add support for reg_write_batch * Adjust x86 MSR accessors * Turn asserts into descriptive exceptions * Improve comments and styling * Fix ARM memcpy neon regression test * Modify canonicals import * Introduce ARM CP reg accessors
Highlights:
reg_write_batchandreg_read_batchAPIcpr_readandcpr_write