Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Model instances instead of MappingType instances #24

Open
Rizziepit opened this issue May 20, 2015 · 3 comments
Open

use Model instances instead of MappingType instances #24

Rizziepit opened this issue May 20, 2015 · 3 comments

Comments

@Rizziepit
Copy link
Contributor

Is there a reason we are not using the MappingType.to_object method to convert to model instances, e.g. https://github.com/universalcore/springboard/blob/develop/springboard/views.py#L63?

I want to prevent future issues when schemas change.

@Rizziepit
Copy link
Contributor Author

@miltontony @smn is this issue valid?

@smn
Copy link
Contributor

smn commented May 20, 2015

No, the only reason that's not used is because when this was writing the only option available was to either hit Git or work with whatever ES returned.

@smn
Copy link
Contributor

smn commented May 20, 2015

So, yes, this issue is valid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants