Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support formatOptions.date to optionally hide date #101

Merged
merged 4 commits into from
Aug 4, 2020
Merged

feat: support formatOptions.date to optionally hide date #101

merged 4 commits into from
Aug 4, 2020

Conversation

develohpanda
Copy link
Contributor

@develohpanda develohpanda commented Aug 2, 2020

If formatOptions.date is false, the date won't show. (Screenshot out of date)

image

Defaults to true (same as current behavior).

image

Closes https://cmty.app/nuxt/consola/issues/c75

@develohpanda develohpanda changed the title Gracefully handle blank date-format in the fancy reporter Add formatOptions.dateVisible to basic/fancy formatters Aug 2, 2020
src/reporters/basic.js Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. Rest LGTM

@develohpanda develohpanda changed the title Add formatOptions.dateVisible to basic/fancy formatters Add formatOptions.date to basic/fancy formatters Aug 4, 2020
@develohpanda develohpanda requested a review from pi0 August 4, 2020 04:07
@pi0 pi0 changed the title Add formatOptions.date to basic/fancy formatters feat: support formatOptions.date to optionally hide date Aug 4, 2020
@pi0 pi0 merged commit 6bf733f into unjs:master Aug 4, 2020
@develohpanda
Copy link
Contributor Author

Thanks for the quick release! Already consumed c6edd4b (#2466) 😄

@develohpanda develohpanda deleted the feature/support-blank-date-format branch August 6, 2020 20:33
nevilm-lt pushed a commit to nevilm-lt/consola that referenced this pull request Apr 22, 2022
himanshiLt pushed a commit to himanshiLt/consola that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants