Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send 204 response if null is returned from handler #154

Merged
merged 7 commits into from
Aug 1, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 27, 2022

#152

Also fixes a bug where a number or boolean value would crash response.

@danielroe danielroe added the enhancement New feature or request label Jul 27, 2022
@danielroe danielroe requested a review from pi0 July 27, 2022 14:49
@danielroe danielroe self-assigned this Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #154 (5625320) into main (821c286) will increase coverage by 0.00%.
The diff coverage is 40.00%.

❗ Current head 5625320 differs from pull request most recent head 2420229. Consider uploading reports for the commit 2420229 to get more accurate results

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          14       14           
  Lines         846      849    +3     
  Branches      175      176    +1     
=======================================
+ Hits          558      560    +2     
  Misses        118      118           
- Partials      170      171    +1     
Impacted Files Coverage Δ
src/utils/response.ts 58.06% <0.00%> (ø)
src/app.ts 67.81% <50.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821c286...2420229. Read the comment docs.

src/app.ts Outdated Show resolved Hide resolved
test/app.test.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat!: send 204 response if null is returned from handler feat: send 204 response if null is returned from handler Aug 1, 2022
@pi0
Copy link
Member

pi0 commented Aug 1, 2022

Marking as semver-minor as null usage is rare.

@pi0 pi0 merged commit dbd465f into main Aug 1, 2022
@pi0 pi0 deleted the feat/204 branch August 1, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants