fix: initialise res.req
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Mar 30, 2022
src/event.ts
Outdated
| res.req.res = res | ||
| // @ts-ignore | ||
| res.req.req = req | ||
| res.req = req |
There was a problem hiding this comment.
Node.js standard res has a req property attached to which is a little bit different than the incoming req!
I think this is originating from unenv mocks that res.req is unset.
There was a problem hiding this comment.
maybe we can just check if res.req exists then? (and possibly also resolve in unenv mock)
There was a problem hiding this comment.
Or we could add res.req polyfill if not existing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise
res.reqis undefined