Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow peerDeps as import entry points #43

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Jan 27, 2022

PR context

Let's say I have next in peerDependencies, and the following import in my package:

import something from "next/head"

When building the package with unbuild, it shows a warning: Potential implicit dependencies found: next/head, while I think it should be legal to use import from peerDeps.

Let me know if I should make any changes.


Thank you for building unbuild 🔥

test/validate.test.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title Allow peerDeps as import entry points feat: allow peerDeps as import entry points Jan 27, 2022
@pi0 pi0 merged commit 755981d into unjs:main Jan 27, 2022
@pi0
Copy link
Member

pi0 commented Jan 27, 2022

Thanks!

@beerose beerose deleted the peer-deps-validate-deps branch February 1, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants