Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Situation with docker image #1103

Open
xermicus opened this issue May 8, 2023 · 3 comments
Open

Situation with docker image #1103

xermicus opened this issue May 8, 2023 · 3 comments

Comments

@xermicus
Copy link
Contributor

xermicus commented May 8, 2023

Currently, the README.md pretends that instead of compiling cargo contract from sources, there is the option to use the docker image paritytech/contracts-ci-linux:production. This image doesn't exist.

There is the paritytech/contracts-ci-linux:latest image, however it contains cargo contract from whatever was in the master branch at the time the image was built. With the current latest image (sha256:dbfd21eb3b023a8cd00be74308a77b624fcc798001889247642b18a8f414e90f), it fails to build contracts created with the latest release v2.2.1:

error[E0601]: `main` function not found in crate `contract`
  --> /opt/contract/lib.rs:41:2
   |
41 | }
   |  ^ consider adding a `main` function to `/opt/contract/lib.rs`

But even if the paritytech/contracts-ci-linux:production image would exist, it'd be unclear what it actually contains. I think it'd be great if we had a dedicated cargo-contract docker image, with tags corresponding to releases.

@cmichi
Copy link
Collaborator

cmichi commented May 8, 2023

I think it'd be great if we had a dedicated cargo-contract docker image, with tags corresponding to releases. WDYT?

Could be married with #1065.

@ltfschoen
Copy link

ltfschoen commented May 11, 2023

@ltfschoen
Copy link

ltfschoen commented May 25, 2023

for development i just created a Dockerfile at https://github.com/ltfschoen/InkTest that contains both https://github.com/paritytech/scripts/blob/master/dockerfiles/base-ci-linux/Dockerfile and https://github.com/paritytech/scripts/blob/master/dockerfiles/contracts-ci-linux/Dockerfile so i have more control, but i seem to be having a port issue #1108

i resolved it by doing this ltfschoen/XCMTemplate#1 (comment)
but i'm just using docker not docker compose now.
i also decided to add an optional CLI option "with_node" to conditionally install substrate-contracts-node, since it takes a long time to build that, and users on less powerful machines who are going to be deploying to a remote testnet rather than local anyway might prefer that.
i've incorporated both ink! Python as well as ink! Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants