Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo workspace: inherit package fields from workspace.package #1447

Closed
lirc571 opened this issue Jan 3, 2024 · 1 comment
Closed

Cargo workspace: inherit package fields from workspace.package #1447

lirc571 opened this issue Jan 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@lirc571
Copy link

lirc571 commented Jan 3, 2024

Is your feature request related to a problem? Please describe.
Building with cargo contract build --manifest-path=contract/Cargo.toml fails if Cargo.toml has the following:

[package]
edition.workspace = true
version.workspace = true
authors.workspace = true
# and more from https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table

Error message:

 [==] Building cargo project
error: failed to parse manifest at `/tmp/cargo-contract_7MeJpP/contract/Cargo.toml`

Caused by:
  error inheriting `edition` from workspace root manifest's `workspace.package.edition`

Caused by:
  `workspace.package.edition` was not defined

Describe the solution you'd like
#1358 adds support for workspace dependencies. The same approach can be used for package fields.

Describe alternatives you've considered
NA

Additional context
NA

@lirc571 lirc571 added the enhancement New feature or request label Jan 3, 2024
@lirc571
Copy link
Author

lirc571 commented Feb 5, 2024

Duplicated #1265.

@lirc571 lirc571 closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant