-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start redirecting away from galaxyproject.eu #421
base: master
Are you sure you want to change the base?
Conversation
- Redirect news/events pages to .org. - Redirect rest to usegalaxy-eu.github.io.
return 301 https://galaxyproject.org/bare/eu/events/; | ||
} | ||
|
||
# Everything else can keep being served by the European website, but under the github.io domain. | ||
location / { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this you have above already, isn't it? Does this need to include here some wildcard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of other pages not caught by the cases above. Those need to still be accessible, but we want to just change the domain. Or did I misunderstand your question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't 301 it, please just leave current proxying in place. I'd rather people don't end up at github.io, that's not a domain we want them to know exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @bgruening wanted to move away from the galaxyproject.eu domain. The 301s above the catch-all send most traffic to galaxyproject.org, and people only end up at usegalaxy-eu.github.io for pages that aren't migrated yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the plan is to redirect the entire galaxyproject.eu domain to org, but the URL should stay galaxyproject.eu. I think projects need that. However, pages that have not yet been migrated should be redirected to the GitHub page temporarily... Until we have migrated every feature and all.subpages. e.g the webhooks will still work but are redirected to the GitHub URL. Or old posts with the old links will still work until we have redirect for all imported posts to the new post. Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying. And by GitHub URL you mean usegalaxy-eu.github.io? That was my understanding. This PR implements that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Does this sounds ok to you @hexylena ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the plan is to redirect the entire galaxyproject.eu domain to org, but the URL should stay galaxyproject.eu. I think projects need that
so not redirecting but proxying?
However, pages that have not yet been migrated should be redirected to the GitHub page temporarily...
again assuming you mean proxied here
If both of those are true, then, yes, agreed :)
I'm moving this back to a draft because we're not quite ready to launch yet. But we will be soon, so I wanted to stage this here. |
See usegalaxy-eu/website#1053 for reasoning.
This implements the 301 redirects from the plan here, and redirects the rest of the pages to usegalaxy-eu.github.io, in order to migrate away from the galaxyproject.eu domain.