-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SharedTemporaryFile (bis) #769
Conversation
All MPI ranks need to be looking at the same temporary file
Add a test maybe? Also add to linter? |
Works for me and documentation looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice docstrings! 👍
E.g, def SharedTemporaryFile(mode='w+b', buffering=-1, encoding=None,
newline=None, suffix="", prefix=template,
dir=None, delete=True, communicator=parallelComm): to def SharedTemporaryFile(
mode="w+b",
buffering=-1,
encoding=None,
newline=None,
suffix="",
prefix=template,
dir=None,
delete=True,
communicator=parallelComm,
): which leads to
The hell with linting. |
linting is stupid
Create a temporary file shared by all MPI ranks
(Previous attempt #767 got broken)