Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default rpm package summary value if it's missing #9427

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

m-czernek
Copy link
Contributor

@m-czernek m-czernek commented Nov 1, 2024

What does this PR change?

An RPM package may not set any summary in the RPM header. Technically, this is an invalid RPM package, but reposync can handle this case.

  • DONE

Documentation

  • No documentation needed: Internal bugfix

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: Internal bugfix

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25668
Port(s):

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@m-czernek m-czernek requested a review from a team as a code owner November 1, 2024 14:05
@m-czernek m-czernek requested review from vzhestkov and removed request for a team November 1, 2024 14:05
ycedres
ycedres previously approved these changes Dec 9, 2024
@m-czernek m-czernek merged commit f0d8c41 into uyuni-project:master Dec 9, 2024
23 checks passed
@m-czernek m-czernek deleted the rpmimport-fix branch December 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants