Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle frontend folder from different locations #1812

Closed
qtdzz opened this issue Jul 23, 2018 · 6 comments
Closed

Handle frontend folder from different locations #1812

qtdzz opened this issue Jul 23, 2018 · 6 comments
Assignees
Milestone

Comments

@qtdzz
Copy link
Contributor

qtdzz commented Jul 23, 2018

Steps to reproduce

  1. Pull the latest master of bakery-flow-spring project
  2. Create a design

Actual behavior

  • Designer suggests creating a design at src/main/webapp/frontend while all of the other designs are in resource/static/frontend
  • The polymer import is <link rel="import" href="../../../../../../webapp/frontend/bower_components/polymer/polymer.html">

Expected behavior

  • Designer will suggest the place where all other designs are located
  • Import link should look better

IDE, Designer and OS version

IntelliJ, Designer 3.0.5, Linux

@qtdzz qtdzz changed the title Suggest a better design location for bakery flow spring project Handle frontend folder from different locations Jul 23, 2018
@szolo
Copy link
Contributor

szolo commented Jul 25, 2018

Alex (@alexberazouski) from Pro also confirmed that even our existing behavior is strange sometimes. After right-clicking on some folder he was expecting this folder to be proposed in "New Design" wizard. Instead some default value was used. Moreover, directory for this default value hasn't existed in the project. We need to improve our wizard logic.

👍

@ripla ripla added the backlog label Aug 2, 2018
@ripla
Copy link
Contributor

ripla commented Aug 2, 2018

Prioritised. The wizard should adhere to the existing spec and all should be well:

  • Hiptest Status
  • Hiptest Status
  • Hiptest Status
  • Hiptest Status

Also updated the path in the Spring scenario Hiptest Status

@szolo
Copy link
Contributor

szolo commented Aug 7, 2018

Erik (@eriklumme) also reported couple of issues with existing Vaadin Spring starter:

  1. When creating a new Design folder webapp/frontend is proposed instead of webapp/frontend/src.
  2. Shared styles couldn't be found in path src/main/resources/META-INF/resources/frontend/styles/shared-styles.html.

shared-styles.html should be considered in this card as well since they also reside inside frontend folder.

@ripla
Copy link
Contributor

ripla commented Aug 7, 2018

@szolo good additions. I don't think the webapp/frontend/src is valid though. frontend is a folder that has special meaning for Flow, while src is just a convention. We could still offer it but I wouldn't say it's necessary.

@anssit anssit self-assigned this Aug 8, 2018
@ripla
Copy link
Contributor

ripla commented Aug 8, 2018

@ripla
Copy link
Contributor

ripla commented Aug 8, 2018

#1612
#1613

@szolo szolo self-assigned this Aug 8, 2018
@szolo szolo added this to the 3.1.1 milestone Aug 28, 2018
@szolo szolo closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants