-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start from a layout template #1857
Comments
Initial design from @anssit |
Has there already been a discussion about what presets to offer there? The current ones in the mockup seem like a nice starting point. I might want to add “Form” there as well, as I would expect that to be one of Designer’s primary use cases? Also, would the header/footer/sidebar layouts utilize App Layout somehow, or would the plan be to create something custom? App Layout doesn’t have a footer. |
The presets in the design are the initial suggestion, but we could have others as well. The idea is to offer shortcuts for layouting. We can use whatever we want for the contents, although a combination of VL+HL would play nicely to the upcoming drag'n'drop functionality. |
I didn’t have any improvements ideas for this at this point. Just some minor visual design things. Hover and drag over styles. I’m not certain similar styles are in use in the app at the moment (using the blue color for interaction cues), so be critical about that. If it seems to stick out, let’s find something that is more aligned with the existing visuals. Figma: https://www.figma.com/file/X7eKoiF0T7Jp36BGOqlPHupC/Designer-Select-View-Layout?node-id=44%3A2 |
Hello, I implemented some snippets and would like to receive the feedback: Vertical:
Horizontal:
Header & footer:
Sidebar:
Header & footer and sidebar:
|
Make sure we have enough contrast for the content users will most likely place in the layout. As a rule, the body text color in Lumo should be sufficient on top of Is the reason for setting the background color for vertical and horizontal layouts to give a stronger indication that something happened? Or is it to show an example how to add inline styles in general? My intuition said I would avoid setting the bg color in those simple cases. Why Make sure you use Same with Should we use Lumo size properties instead of fixed pixel sizes for the widths/heights? |
I'll check how it will look like and use contrast-20pct if everything will be ok.
Yes, it's for the purpose of the stronger indication. There is no guarantee that user will continue with our background colors. But at least at the starting point user will see how the structure looks like.
What do you mean? I can remove it, but its more explicit.
Yep, I tested it. Behaves like it should. Thanks for pointing on this.
Will do.
Yeah, why not. Any recommendations? |
Note, that this only applies for one layer of that color. As it’s semi-transparent, once you start stacking more layouts with this background color, the contrast (for body text) will go below requirements. Therefore, I would suggest first trying with |
With That said, it’s your decision. |
Not really. Again, I think I can leave the decision to you. |
|
Talked to Jouni, we agreed to remove The starting page looks bad in mobile size, I'll try these two solutions in order:
|
Small correction: until we have a better understanding how to help in creating forms with Designer 🤗 |
@jouni So this is how scrollable area looks like: Styling:
You can check it by yourself via the repo |
It should be easy & fast for the user to get started with Designer. The Designer should provide a way to select a base layout to get started
UX
The text was updated successfully, but these errors were encountered: