Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data binding in embedded template doesn't work #1907

Closed
szolo opened this issue Oct 25, 2018 · 1 comment
Closed

Data binding in embedded template doesn't work #1907

szolo opened this issue Oct 25, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@szolo
Copy link
Contributor

szolo commented Oct 25, 2018

Issue 1

Steps to reproduce

  1. Import the project: https://github.com/vaadin/designer/files/2778287/skeleton-starter-flow.zip
  2. Open my-view.html in Preview

Actual behaviour

The dom-repeat contents inside the embedded component are not rendered:
screenshot 2019-01-21 at 13 13 09

Expected behaviour

The dom-repeat is bound correctly to the data and it's shown:
screenshot 2019-01-21 at 13 12 49

Issue 2

Steps to reproduce

  1. Import the project: https://github.com/vaadin/designer/files/2778287/skeleton-starter-flow.zip
  2. Open my-view.html in Edit

Actual behaviour

The dom-repeat inside the embedded component is rendered:
screenshot 2019-01-21 at 13 13 23

Expected behaviour

The dom-repeat is not rendered, but the contents is displayed.

IDE, Designer and OS version

Windows 10, Designer 4.1.1, latest IntelliJ.

Notes

Originally reported by @anssit. I have a feeling that it's somehow related to the property, which is used in data binding. Since it's item it means that it's not declared explicitly in the corresponding web component.

I also investigate a bit and it looks like that in preview mode for main-view our artificial _internalDesignerGetTextContent is still used. This is not the case for product-view: it contains only data bindings in preview mode. This behavior needs to be investigated and aligned.

@anssit
Copy link
Contributor

anssit commented Jan 21, 2019

skeleton-starter-flow.zip
A simpler test project. See my-view.html in preview mode: Array items are not displayed.

@ripla ripla self-assigned this Jan 21, 2019
@szolo szolo self-assigned this Jan 21, 2019
@ripla ripla added editor and removed preview labels Jan 22, 2019
@szolo szolo added this to the 4.2.0 milestone Jan 31, 2019
@szolo szolo closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants