Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show information popup for missing dependencies #2106

Closed
szolo opened this issue Jul 27, 2019 · 1 comment
Closed

Show information popup for missing dependencies #2106

szolo opened this issue Jul 27, 2019 · 1 comment
Assignees
Milestone

Comments

@szolo
Copy link
Contributor

szolo commented Jul 27, 2019

Steps to reproduce

  1. Download default project from start.vaadin.com.
  2. Import it to Designer.
  3. Open any design, e.g. dashboard-view.js.

Actual behavior

Design is opened, but it is empty. Outline contains design structure.

Expected behavior

After design was opened it should be clear why it is empty.

IDE, Designer and OS version

OS: Mac OS X 10.14.5 x86_64
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.24 Safari/537.36
Java: 11.0.2
IntelliJ: IntelliJ IDEA - 2019.1.3 - IC-191.7479.19
Designer: 4.3.1
Vaadin: 0.0.0

Intercom:

Summary

Dependencies for design aren't installed until mvn package is not executed. For New Design wizard we're checking that node_modules folder exists. Similar should be done for opening already existing designs.

@szolo
Copy link
Contributor Author

szolo commented Jul 31, 2019

In Eclipse we already have a dialog, which is visible and suggests to execute mvn package. In IntelliJ IDEA we don't have it, because error log at the IDE bottom is used.
So, we need to adjust existing IntelliJ code a bit and show a popup message, because log record could be missed accidentally by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants