I receive IDONTWANT from nimbus, even if I'm a gossipsub v1.1 node

[ppopth]

I ran a Prysm node which supports only Gossipsub v1.1, I expected Nimbus not to send me IDONTWANT because it has no use and waste the bandwidth, but I still receive IDONTWANT from nimbus.

[kaiserd]

Thanks a lot for bringing this to our attention.

Sorry for the late replay (holiday season).
I wanted to give you a quick update on the situation: In the current version of nim-libp2p, gossipsub v1.1 shouldn't be sending IDONTWANT messages anymore.
We had actually added IDONTWANT to v1.1 in a previous version as a temporary measure before v1.2 was released.
@richard-ramos is going to investigate this further and will get back with more details soon.

[richard-ramos]

Looking into this, the code that fixes this issue was introduced in #113 , we're excluding sending IDONTWANT messages to peers using gossipsub < 1.2

nim-libp2p/libp2p/protocols/pubsub/gossipsub.nim

Lines 414 to 416 in 1fa30f0

	peersToSendIDontWant.exclIfIt(
	it.codec == GossipSubCodec_10 or it.codec == GossipSubCodec_11
	)

I could observe that this is behaving correctly in the test case https://github.com/vacp2p/nim-libp2p/blob/master/tests/pubsub/testgossipsub.nim#L931 . This nim-libp2p version landed in nimbus stable (on v24.7.0) in status-im/nimbus-eth2#6422 on this commit: status-im/nimbus-eth2@031033a

@ppopth If possible can you share more details about these peers sending you IDONTWANT messages? I wonder if those are running a very old version of nimbus