You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
threat as optional all empty fields but instead we should take better decision
Not sure exactly what this is referring to, but for Waku, having some of that optionality is a feature when it comes to things like metadata protection. Eth2 have slightly different design requirements I believe, so allowing for both would be useful.
The overall picture is ok, obviously likely not bug free but feature wise almost complete.
Few missing things are:
encodeMessage
- currently we threat as optional all empty fields but instead we should take better decisions, also there is this PR that will influence this: gossipsub v1.1: introduce message signing policy libp2p/specs#294decodePrune
- decode the new gossip 1.1 fieldsThe text was updated successfully, but these errors were encountered: