Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossipsub further improvements #365

Closed
3 of 4 tasks
sinkingsugar opened this issue Sep 15, 2020 · 2 comments
Closed
3 of 4 tasks

Gossipsub further improvements #365

sinkingsugar opened this issue Sep 15, 2020 · 2 comments
Assignees

Comments

@sinkingsugar
Copy link
Contributor

sinkingsugar commented Sep 15, 2020

The overall picture is ok, obviously likely not bug free but feature wise almost complete.

Few missing things are:

@sinkingsugar sinkingsugar self-assigned this Sep 15, 2020
@oskarth
Copy link
Contributor

oskarth commented Sep 16, 2020

threat as optional all empty fields but instead we should take better decision

Not sure exactly what this is referring to, but for Waku, having some of that optionality is a feature when it comes to things like metadata protection. Eth2 have slightly different design requirements I believe, so allowing for both would be useful.

EDIT: Looking at https://github.com/ethereum/eth2.0-specs/pull/2060/files I see the StrictNoSign policy seems to overlap with Waku goals.

@dryajov
Copy link
Contributor

dryajov commented Feb 2, 2021

Most of this is implemented except the changes introduced in libp2p/specs#292, which is now tracked by #513

@dryajov dryajov closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants