-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete and import vals #8
base: main
Are you sure you want to change the base?
Conversation
"valtown.autoImport.staticVersion": { | ||
"type": "boolean", | ||
"markdownDescription": "Use a static version when automatically importing vals, like this.\n\n| Option | Example |\n|--------|---------|\n| `false` | `import \"https://esm.town/v/steveKrouse/helloWorld\"` |\n| `true` | `import \"https://esm.town/v/steveKrouse/helloWorld?v=14\"` |\n\nThis is useful for ensuring that your code doesn't break when the val is updated.", | ||
"default": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to think that this should be true by default for parity with the editor.
Hey, thanks a lot for your contribution, it looks incredible! I took a quick look at the code (looks good), and I'll test the extension on my instance of vscode tomorrow. I wonder if all these customization options are necessary. I would vote for just following whatever behaviour the website editor has, so the end user doesn't get confused. |
For parity with the val.town editor, adds:
Please test:
@[<handle>[/<val>]]